linux-kernel - Re: [ 19/49] NFSv4: Add ACCESS operation to OPEN compound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1358298537.15692.101.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 16 Jan 2013 01:08:57 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Weston Andros Adamson <dros@...app.com>,
	Trond Myklebust <Trond.Myklebust@...app.com>
Subject: Re: [ 19/49] NFSv4: Add ACCESS operation to OPEN compound

On Tue, 2013-01-15 at 16:42 -0200, Herton Ronaldo Krzesinski wrote:
> On Sun, Jan 13, 2013 at 05:43:14PM +0000, Ben Hutchings wrote:
> > 3.2-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Weston Andros Adamson <dros@...app.com>
> > 
> > commit 6168f62cbde8dcf4f58255794efbcdb8df603959 upstream.
> > 
> > The OPEN operation has no way to differentiate an open for read and an
> > open for execution - both look like read to the server. This allowed
> > users to read files that didn't have READ access but did have EXEC access,
> > which is obviously wrong.
> > 
> > This patch adds an ACCESS call to the OPEN compound to handle the
> > difference between OPENs for reading and execution.  Since we're going
> > through the trouble of calling ACCESS, we check all possible access bits
> > and cache the results hopefully avoiding an ACCESS call in the future.
> > 
> > Signed-off-by: Weston Andros Adamson <dros@...app.com>
> > Signed-off-by: Trond Myklebust <Trond.Myklebust@...app.com>
> > [bwh: Backported to 3.2:
> >  - Adjust context
> >  - #include <linux/export.h> in fs/nfs/dir.c]
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> 
> This 3.2 series lacks commit ae2bb03236fc978bdf673c19d39832500793b83c
> pointed in its changelog as fixing a regression from this one.

Thanks.  Actually I'm not at all confident about the adjustments to
these NFSv4 access changes, so I'll drop them all for now.

Ben.

-- 
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)