linux-kernel - Re: [PATCH 06/18] power: ab8500_bm: Recharge condition not optimal for battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130116084714.GE9379@gmail.com>
Date:	Wed, 16 Jan 2013 08:47:14 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Anton Vorontsov <anton.vorontsov@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arnd@...db.de, linus.walleij@...ricsson.com,
	Marcus Cooper <marcus.xm.cooper@...ricsson.com>
Subject: Re: [PATCH 06/18] power: ab8500_bm: Recharge condition not optimal
 for battery

On Tue, 15 Jan 2013, Anton Vorontsov wrote:

> On Fri, Jan 11, 2013 at 01:12:54PM +0000, Lee Jones wrote:
> > From: Marcus Cooper <marcus.xm.cooper@...ricsson.com>
> > 
> > Today the battery recharge is determined with a voltage threshold. This
> > voltage threshold is only valid when the battery is relaxed. In charging
> > algorithm the voltage read is the loaded battery voltage and no
> > compensation is done to get the relaxed voltage. When maintenance
> > charging is not selected, this makes the recharging condition to almost
> > immediately activate when there is a discharge present on the battery.
> > 
> > Depending on which vendor the battery comes from this behavior can wear
> > out the battery much faster than normal.
> > 
> > The fuelgauge driver is responsible to monitor the actual battery
> > capacity and is able to estimate the remaining capacity. It is better to
> > use the remaining capacity as a limit to determine when battery should
> > be recharged.
> > 
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > Signed-off-by: Marcus Cooper <marcus.xm.cooper@...ricsson.com>
> > Reviewed-by: Hakan BERG <hakan.berg@...ricsson.com>
> > Reviewed-by: Jonas ABERG <jonas.aberg@...ricsson.com>
> > ---
> > +	.maint_thres = 95,
> >  	.user_cap_limit = 15,
> >  	.maint_thres = 97,
> >  };
> 
> 95 or 97? These are both specified. I removed 97, assuming it was a merge
> error on your side. But please double check, it could be that you really
> want 97 here.

You did the correct thing, thanks.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/