linux-kernel - Re: [PATCH 06/13] perf ui/hist: Add support for event group view

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130116181416.GM5826@ghostprotocols.net>
Date:	Wed, 16 Jan 2013 15:14:16 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Stephane Eranian <eranian@...gle.com>,
	Namhyung Kim <namhyung.kim@....com>
Subject: Re: [PATCH 06/13] perf ui/hist: Add support for event group view

Em Wed, Jan 16, 2013 at 06:22:49PM +0900, Namhyung Kim escreveu:
> On Tue, 15 Jan 2013 15:31:10 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 15, 2013 at 04:31:50PM +0900, Namhyung Kim escreveu:
> >> From: Namhyung Kim <namhyung.kim@....com>
> >> 
> >> Show group members' overhead also when showing the leader's if event
> >> group is enabled.  Use macro for defining hpp functions which looks
> >> almost identical.
> >> 
> >> Thanks to Arnaldo for suggesting a better way to print group members
> >> without allocating temporary array.
> >
> > Thanks! Its a pity the patch ended up mixing up things, I'll have to
> > apply it and look at the end result.
> 
> Do you mean I have to separate this into two - one for converting to
> macro and another for event group view itself?

If you can, please, that way we may see more clearly each of these
changes in the separated patches.

Thanks,

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/