linux-kernel - Re: [PATCH 03/10] goldfish: tty driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130116182520.64b1fe6a@pyramind.ukuu.org.uk>
Date:	Wed, 16 Jan 2013 18:25:20 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	<balbi@...com>
Cc:	Alan Cox <alan@...ux.intel.com>, <arve@...roid.com>,
	<x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<mikechan@...gle.com>
Subject: Re: [PATCH 03/10] goldfish: tty driver

On Wed, 16 Jan 2013 19:01:22 +0200
Felipe Balbi <balbi@...com> wrote:

> Hi,
> 
> On Wed, Jan 16, 2013 at 04:59:03PM +0000, Alan Cox wrote:
> > +static int goldfish_tty_probe(struct platform_device *pdev)
> > +{
> > +	struct goldfish_tty *qtty;
> > +	int ret = -EINVAL;
> > +	int i;
> > +	struct resource *r;
> > +	struct device *ttydev;
> > +	void __iomem *base;
> > +	u32 irq;
> > +
> > +	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	if(r == NULL)
> > +		return -EINVAL;
> > +
> > +	base = ioremap(r->start, 0x1000);
> 
> missing request_mem_region(), in fact you could just use
> devm_request_and_ioremap().

Actually the reservation is already done by the bus driver. If it sees
the goldfish interface it reserves the entire chunk and the emulator then
tells it which is in each chunk of that range.

It's reserving it as the wrong type however so I do need to fix that.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/