linux-kernel - Re: [PATCH 23/33] pwm: Convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOh2x=nCv23SLzM6uyFKFJtcgHSuEpGcGEhf6QL7GLm+Z_RzEA@mail.gmail.com>
Date:	Mon, 21 Jan 2013 16:19:48 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Wolfram Sang <w.sang@...gutronix.de>
Subject: Re: [PATCH 23/33] pwm: Convert to devm_ioremap_resource()

On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
<thierry.reding@...onic-design.de> wrote:
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 83b21d9..69a2d9e 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -192,9 +192,9 @@ static int spear_pwm_probe(struct platform_device *pdev)
>                 return -ENOMEM;
>         }
>
> -       pc->mmio_base = devm_request_and_ioremap(&pdev->dev, r);
> -       if (!pc->mmio_base)
> -               return -EADDRNOTAVAIL;
> +       pc->mmio_base = devm_ioremap_resource(&pdev->dev, r);
> +       if (IS_ERR(pc->mmio_base))
> +               return PTR_ERR(pc->mmio_base);
>
>         pc->clk = devm_clk_get(&pdev->dev, NULL);
>         if (IS_ERR(pc->clk))

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/