linux-kernel - Re: [PATCH 24/33] rtc: Convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOh2x=nQga2umyMMdZ0R2sFj0iY2p3wXVGQ62yV24cVSoHTCPA@mail.gmail.com>
Date:	Mon, 21 Jan 2013 16:20:28 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH 24/33] rtc: Convert to devm_ioremap_resource()

On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
<thierry.reding@...onic-design.de> wrote:
> diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
> index c2121b5..a18c319 100644
> --- a/drivers/rtc/rtc-spear.c
> +++ b/drivers/rtc/rtc-spear.c
> @@ -385,11 +385,9 @@ static int spear_rtc_probe(struct platform_device *pdev)
>                 return status;
>         }
>
> -       config->ioaddr = devm_request_and_ioremap(&pdev->dev, res);
> -       if (!config->ioaddr) {
> -               dev_err(&pdev->dev, "request-ioremap fail\n");

can we keep it as is?

> -               return -ENOMEM;
> -       }
> +       config->ioaddr = devm_ioremap_resource(&pdev->dev, res);
> +       if (IS_ERR(config->ioaddr))
> +               return PTR_ERR(config->ioaddr);
>

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/