linux-kernel - Re: [PATCH 08/33] gpio: Convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOh2x=ne_Oe7V=BzjQJtuPv20syorLTq-C89aKQDo4JK78Y8YA@mail.gmail.com>
Date:	Mon, 21 Jan 2013 16:22:21 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 08/33] gpio: Convert to devm_ioremap_resource()

On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
<thierry.reding@...onic-design.de> wrote:
> diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
> index 5f45fc4..7a4bf7c 100644
> --- a/drivers/gpio/gpio-spear-spics.c
> +++ b/drivers/gpio/gpio-spear-spics.c
> @@ -140,11 +140,9 @@ static int spics_gpio_probe(struct platform_device *pdev)
>                 return -ENOMEM;
>         }
>
> -       spics->base = devm_request_and_ioremap(&pdev->dev, res);
> -       if (!spics->base) {
> -               dev_err(&pdev->dev, "request and ioremap fail\n");

can we keep it as is?

> -               return -ENOMEM;
> -       }
> +       spics->base = devm_ioremap_resource(&pdev->dev, res);
> +       if (IS_ERR(spics->base))
> +               return PTR_ERR(spics->base);
>


Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/