linux-kernel - Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130121171313.GC4997@kroah.com>
Date:	Mon, 21 Jan 2013 09:13:13 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Fangxiaozhi (Franko)" <fangxiaozhi@...wei.com>
Cc:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Xueguiying (Zihan)" <zihan.xue@...wei.com>,
	"Linlei (Lei Lin)" <lei.lin@...wei.com>,
	"Yili (Neil)" <neil.yi@...wei.com>,
	"Wangyuhua (Roger, Credit)" <wangyuhua@...wei.com>,
	"Huqiao (C)" <huqiao36@...wei.com>, "balbi@...com" <balbi@...com>,
	"mdharm-usb@...-eyed-alien.net" <mdharm-usb@...-eyed-alien.net>,
	"sebastian@...akpoint.cc" <sebastian@...akpoint.cc>
Subject: Re: USB: storage: optimize the matching rules and support new switch
 command for Huawei USB storage devices

On Mon, Jan 21, 2013 at 03:41:20AM +0000, Fangxiaozhi (Franko) wrote:
> Dear Greg:
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > Sent: Saturday, January 19, 2013 7:42 AM
> > To: Fangxiaozhi (Franko)
> > Cc: linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Xueguiying (Zihan);
> > Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); balbi@...com;
> > mdharm-usb@...-eyed-alien.net; sebastian@...akpoint.cc
> > Subject: Re: USB: storage: optimize the matching rules and support new switch
> > command for Huawei USB storage devices
> > 
> > On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote:
> > >
> > > From: fangxiaozhi <huananhu@...wei.com>
> > >
> > > 1. Optimize the matching rules with new macro for Huawei USB storage
> > >    devices, to avoid to load USB storage driver for the modem interface
> > >    with Huawei devices.
> > > 2. Add to support new switch command for new Huawei USB dongles.
> > >
> > > Signed-off-by: fangxiaozhi <huananhu@...wei.com>
> > 
> > Next time, please always use the scripts/checkpatch.pl tool to find any
> > problems you might have made in your patch (you had trailing whitespace in
> > this one, which I have fixed.)
> > 
> -----Yes, I have checked my patch with scripts/checkpatch.pl tool before submitting.

Then where did the trailing whitespace come from?

> -----For this trailing whitespace error, I think that it is better
> readable to leave whitespace in our patch code. Isn't it?

Not at the end of lines for no reason, right?

Please fix up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/