linux-kernel - RE: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <910F9D9E13B84F4C8FA771DC9BDE99F32701CC26@szxeml546-mbx.china.huawei.com>
Date:	Tue, 22 Jan 2013 09:16:08 +0000
From:	"Fangxiaozhi (Franko)" <fangxiaozhi@...wei.com>
To:	Greg KH <greg@...ah.com>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Xueguiying (Zihan)" <zihan.xue@...wei.com>,
	"Linlei (Lei Lin)" <lei.lin@...wei.com>,
	"Yili (Neil)" <neil.yi@...wei.com>,
	"Wangyuhua (Roger, Credit)" <wangyuhua@...wei.com>,
	"Huqiao (C)" <huqiao36@...wei.com>, "balbi@...com" <balbi@...com>,
	"mdharm-usb@...-eyed-alien.net" <mdharm-usb@...-eyed-alien.net>,
	"sebastian@...akpoint.cc" <sebastian@...akpoint.cc>
Subject: RE: USB: storage: optimize the matching rules and support new
 switch command for Huawei USB storage devices

Dear Greg:

	OK, I have fixed up and resend the patches based on linux-3.8-rc4 today.

	Email subjects:
		1. [PATCH 1/2]linux-usb:define new macro and add new match rules for Huawei USB storage devices
		2. [PATCH 2/2]linux-usb:define new macro and add new match rules for Huawei USB storage devices

	Please apply them, thank you very much.

Best Regards,
Franko Fang
> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: Tuesday, January 22, 2013 1:12 AM
> To: Fangxiaozhi (Franko)
> Cc: linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Xueguiying (Zihan);
> Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); balbi@...com;
> mdharm-usb@...-eyed-alien.net; sebastian@...akpoint.cc
> Subject: Re: USB: storage: optimize the matching rules and support new switch
> command for Huawei USB storage devices
> 
> On Mon, Jan 21, 2013 at 03:37:15AM +0000, Fangxiaozhi (Franko) wrote:
> > Dear Greg:
> >
> > > I get the following errors:
> > >
> > > drivers/usb/storage/unusual_devs.h:1530:1: error: implicit
> > > declaration of function ‘UNUSUAL_VENDOR_INTF’
> > > [-Werror=implicit-function-declaration]
> > > drivers/usb/storage/unusual_devs.h:1534:3: warning: missing braces
> > > around initializer [-Wmissing-braces]
> > > drivers/usb/storage/unusual_devs.h:1534:3: warning: (near
> > > initialization for
> > > ‘us_unusual_dev_list[186]’) [-Wmissing-braces]
> > > drivers/usb/storage/unusual_devs.h:1534:3: error: initializer
> > > element is not constant
> > > drivers/usb/storage/unusual_devs.h:1534:3: error: (near
> > > initialization for
> > > ‘us_unusual_dev_list[186].vendorName’)
> > > drivers/usb/storage/unusual_devs.h:1537:1: warning: braces around
> > > scalar initializer [enabled by default]
> > >
> > > And it goes on and on...
> > ----------The macro define, please see another patch:
> > 	[PATCH 1/1]linux-usb:Define a new macro for USB storage match rules
> > 	http://www.spinics.net/lists/linux-usb/msg76629.html
> 
> Please resend it, I do not have this patch anymore in my queue.
> Remember, I asked you to resend everything that was needed, with the proper
> ordering.
> 
> Please resend all patches, properly fixed up, that you wish to see applied.
> 
> thanks,
> 
> greg k-h