linux-kernel - Re: [PATCH 08/33] gpio: Convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130122102558.GA10716@avionic-0098.adnet.avionic-design.de>
Date:	Tue, 22 Jan 2013 11:25:59 +0100
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH 08/33] gpio: Convert to devm_ioremap_resource()

On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
> On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
> <thierry.reding@...onic-design.de> wrote:
> 
> > Convert all uses of devm_request_and_ioremap() to the newly introduced
> > devm_ioremap_resource() which provides more consistent error handling.
> >
> > devm_ioremap_resource() provides its own error messages so all explicit
> > error messages can be removed from the failure code paths.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@...onic-design.de>
> > Cc: Grant Likely <grant.likely@...retlab.ca>
> > Cc: Linus Walleij <linus.walleij@...aro.org>
> 
> Is the interface already in-kernel so I should apply this or is it
> added as part of this series so you're searching an ACK?

It is part of this series, so your Acked-by would be great. Other
maintainers have done the same. Initially I had thought that it might be
easier if the patches went in through individual trees, but since the
first patch is a dependency, maybe it'd be better to take them all
through a single tree.

Greg, any comments? Would you be willing to take the series through your
driver-core tree once all Acked-bys are there? Alternatively I guess we
could take the first patch into linux-next, at which point maintainers
could take this through the individual trees.

Thierry

Content of type "application/pgp-signature" skipped