linux-kernel - Re: [PATCH] PCI: Document PCIE BUS MPS parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50FFCD3B.8000704@huawei.com>
Date:	Wed, 23 Jan 2013 19:44:59 +0800
From:	Yijing Wang <wangyijing@...wei.com>
To:	Andrew Murray <andrew.murray@....com>, Jon Mason <jdmason@...zu.us>
CC:	Yijing Wang <wangyijing0307@...il.com>,
	Rob Landley <rob@...dley.net>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Hanjun Guo <guohanjun@...wei.com>,
	"jiang.liu@...wei.com" <jiang.liu@...wei.com>
Subject: Re: [PATCH] PCI: Document PCIE BUS MPS parameters

On 2013/1/23 18:30, Andrew Murray wrote:
> On Wed, Jan 23, 2013 at 10:13:02AM +0000, Yijing Wang wrote:
>> ??? 2013-01-23 17:21, Andrew Murray ??????:
>>> On Wed, Jan 23, 2013 at 08:01:36AM +0000, Yijing Wang wrote:
>>>> Document PCIE BUS MPS parameters pcie_bus_tune_off, pcie_bus_safe,
>>>> pcie_bus_peer2peer, pcie_bus_perf into Documentation/kernel-parameters.txt.
>>>> These parameters were introduced by Jon Mason <mason@...i.com> at
>>>> commit 5f39e6705 and commit b03e7495a8. Document these into 
>>>> kernel-parameters.txt help users to understand and use the parameters.
>>>>
>>>> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
>>>> ---
>>>>  Documentation/kernel-parameters.txt |   13 +++++++++++++
>>>>  1 files changed, 13 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
>>>> index 363e348..4dfa8d2 100644
>>>> --- a/Documentation/kernel-parameters.txt
>>>> +++ b/Documentation/kernel-parameters.txt
>>>> @@ -2227,6 +2227,19 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>>>>  				This sorting is done to get a device
>>>>  				order compatible with older (<= 2.4) kernels.
>>>>  		nobfsort	Don't sort PCI devices into breadth-first order.
>>>> +		pcie_bus_tune_off	[X86] Disable PCI-E MPS turning and using
>>>> +				the BIOS configured MPS defaults.
>>>> +		pcie_bus_safe	[X86] Use the smallest common denominator MPS
>>>> +				of the entire tree below a root complex for every device
>>>> +				on that fabric. Can avoid inconsistent mps problem caused
>>>> +				by hotplug.
>>>> +		pcie_bus_perf	[X86] Configure pcie device MPS to the largest
>>>> +				allowable MPS based on its parent bus.Improve performance
>>>> +				as much as possible.
>>>> +		pcie_bus_peer2peer	[X86] Make the system wide MPS the smallest
>>>> +				possible value (128B).This configuration could prevent it
>>>> +				from working by having the MPS on one root port different
>>>> +				than the MPS on another.
>>>>  		cbiosize=nn[KMG]	The fixed amount of bus space which is
>>>>  				reserved for the CardBus bridge's IO window.
>>>>  				The default value is 256 bytes.
>>>>
>>> I was searching for documentation on this the other day.
>>>
>>> It's not just X86 that use these options, PowerPC and Tile also use them (grep
>>> for users of pcie_bus_configure_settings). I've also noticed a call to it from
>>> hotplug as well...
>>
>> Hi Andrew,
>>    Thanks for reminder! I will update this patch right now.
>>
>>>
>>> In addition these options also have an effect on MRRS - I've not figured out
>>> what effect they have, but you can look in drivers/pci/probe.c at the
>>> pcie_write_mrrs function.
>>
>> This is a separate issue, Andrew, can you provide the effetct problem log or detail information?
>> That will helps us to analyze this issue.
> 
> No this isn't a bug. When pcie_bus_perf is set, not only does it change the MPS
> as described in your documentation - but it also changes the MRRS for better
> performance. I felt this should also be included in your documentation of
> pcie_bus_perf.

Will add it.

> 
> The pcie_write_mrrs function uses pcie_bus_config to determine if a change to
> the MRRS should be made.
> 
> (What I don't understand is that the comments in this function suggest the MRRS
> cannot be larger than the MPS - I thought it could be?)

I trace the change log about pcie_write_mrrs() function, my understanding for comment
"it cannot be configured larger than the MPS the device or the bus can support" is that
jon assume "device will never generate packets larger than MPS", so we can focus on upstream
requests. If not, we should also concern the downstream request packet whether can be received by upstream
device normally, maybe upstream mps is smaller than downstream device's mrrs.

> 
> Andrew Murray 
> 
> 
> .
> 


-- 
Thanks!
Yijing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/