linux-kernel - Re: [ANNOUNCE] 3.8-rc4-nohz3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTL4hxxSO6KQ6JKwTCiVG55HBP2w+FE9K9jMzYpgsU8A51U-w@mail.gmail.com>
Date:	Wed, 23 Jan 2013 13:23:22 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	sedat.dilek@...il.com
Cc:	LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [ANNOUNCE] 3.8-rc4-nohz3

2013/1/23 Sedat Dilek <sedat.dilek@...il.com>:
> On Wed, Jan 23, 2013 at 1:11 PM, Frederic Weisbecker <fweisbec@...il.com> wrote:
>> 2013/1/23 Sedat Dilek <sedat.dilek@...il.com>:
>>> On Wed, Jan 23, 2013 at 12:19 PM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>>>> Hi Frederic,
>>>>
>>>> I wanted to 3.8-rc4-nohz3 [1] here on my Ubuntu/precise AMD64 system.
>>>>
>>>> Unfortunately, the build breaks like this:
>>>>
>>>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
>>>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>>>>
>>>
>>> Looks like you tested with CONFIG_KVM=y (as module fails!).
>>
>> Yep. looks like I forgot some EXPORT_SYMBOL().
>>
>
> Hmmm, that was my first thought, too, but about...
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index c243b81..fff0932 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5713,7 +5713,7 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
>         if (req_immediate_exit)
>                 smp_send_reschedule(vcpu->cpu);
>
> -       kvm_guest_enter();
> +       guest_enter();

You still need to keep kvm_guest_enter() here, otherwise you miss the
rcu_virt_note_context_switch().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/