linux-kernel - Re: [PATCH] radeon_display: Use pointer return error codes

Open Source and information security mailing list archives

Message-ID: <CADnq5_Oiq3FrVLeA6uovDQnGrmZ3=gPaH173Q9aw9yMhfWM1kA@mail.gmail.com>
Date:	Wed, 23 Jan 2013 09:14:47 -0500
From:	Alex Deucher <alexdeucher@...il.com>
To:	"Su, Xuemin" <xuemin.su@...el.com>
Cc:	airlied@...ux.ie, airlied@...hat.com, alexander.deucher@....com,
	s.hauer@...gutronix.de, ihadzic@...earch.bell-labs.com,
	laurent.pinchart@...asonboard.com, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, yanmin_zhang@...ux.intel.com,
	bo.he@...el.com
Subject: Re: [PATCH] radeon_display: Use pointer return error codes

On Tue, Jan 22, 2013 at 9:27 PM, Su, Xuemin <xuemin.su@...el.com> wrote:
> From: xueminsu <xuemin.su@...el.com>
> Date: Tue, 22 Jan 2013 22:16:53 +0800
> Subject: [PATCH] radeon_display: Use pointer return error codes
>
> drm_mode_addfb() expects fb_create return error code
> instead of NULL.
>
> Signed-off-by: xueminsu <xuemin.su@...el.com>

Thanks.  Added to my fixes queue.

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 1da2386..ff3def7 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
>         if (ret) {
>                 kfree(radeon_fb);
>                 drm_gem_object_unreference_unlocked(obj);
> -               return NULL;
> +               return ERR_PTR(ret);
>         }
>
>         return &radeon_fb->base;
> --
> 1.7.6
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives