linux-kernel - Re: [PATCH V3] drm_crtc: check if fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878v7juf2v.fsf@intel.com>
Date:	Thu, 24 Jan 2013 11:04:40 +0200
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	"Su\, Xuemin" <xuemin.su@...el.com>
Cc:	airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, yanmin_zhang@...ux.intel.com,
	bo.he@...el.com
Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL

On Thu, 24 Jan 2013, "Su, Xuemin" <xuemin.su@...el.com> wrote:
> On Thu, 2013-01-24 at 10:31 +0200, Jani Nikula wrote:
>> >  	}
>> > +	/* some buggy driver may return NULL here, which may cause panic */
>> > +	BUG_ON(!fb);
>> 
>> I fail to see the benefit of this compared to just letting it oops...
>> 
>> >  	or->fb_id = fb->base.id;
>> 
>> ...right here.
>> 
>> 
> For PATCH V3, I think a BUG_ON may give the user clearer information
> about the reason of panic. Easier to debug.

Ah, sorry, never mind, I missed Daniel's comment. The benefit of the
BUG_ON() is making it clear what's expected of the drivers.

Reviewed-by: Jani Nikula <jani.nikula@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/