linux-kernel - Re: [patch v1 2/5] regulator: da9055 change irq state to default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 Jan 2013 13:56:40 +0530
From:	Ashish Jangam <ashish.jangam@...tcummins.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Liam Girdwood <lrg@...com>, Samuel Ortiz <sameo@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>,
	David Dajun Chen <dchen@...semi.com>
Subject: Re: [patch v1 2/5] regulator: da9055 change irq state to default

On Thu, 2013-01-24 at 00:03 +0800, Mark Brown wrote:
> On Mon, Jan 21, 2013 at 02:05:12PM +0530, Ashish Jangam wrote:
> 
> > > What makes you say that there is a dependency here?  It's really not at
> > > all obvious why a change to the primary IRQ signalling mechanism would
> > > affect the internal interrupts of the device.
> 
> > Yes, functionally this dependency should not matter.However, if
> > mfd/primary irq state is low and its components are high then it shall
> > not look good. Therefore the term dependency was used, probably I should
> > have written it in a different manner.
> 
> This logic doesn't follow terribly directly - looking at what you've
> posted it in fact seems that the trigger type is irrelevant in the
> function drivers?
Though it is functionally irrelevant but in the code setting the primary
irq to low and functional driver to high may confuse the code reader.
However I leave this decision to you.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/