linux-kernel - Re: [PATCH] firmware: Make user-mode helper optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr4l9b6b6.wl%tiwai@suse.de>
Date:	Fri, 25 Jan 2013 17:01:17 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: Make user-mode helper optional

At Fri, 25 Jan 2013 11:12:03 +0800,
Ming Lei wrote:
> 
> On Tue, Jan 22, 2013 at 7:51 PM, Takashi Iwai <tiwai@...e.de> wrote:
> > Since 3.7 kernel, the firmware loader can read the firmware files
> > directly, and the traditional user-mode helper is invoked only as a
> > fallback.  This seems working pretty well, and the next step would be
> > to reduce the redundant user-mode helper stuff in future.
> 
> The idea is good.
> 
> >
> > This patch is a preparation for that, to make the user-mode helper
> > invocation optional via kconfig.  Other than that, there is no
> > functional change here.
> 
> In fact, your patch does much code refactoring work, which isn't
> strictly related with what you claimed in the commit log, at least
> it should be separated from introducing FW_LOADER_USER_HELPER.
> 
> So could you split the patch into several parts and let one part do one thing
> so that we can review them a bit easily?

Fair enough.  Will submit the revised patches soon.

> 
> Also it is not good to introduce too many '#ifdef #endif', IMO.

Heh, that can be much worse :)


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/