linux-kernel - Re: [perf PATCH 3/3] Fix double fclose() on do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130125160151.GA31242@ghostprotocols.net>
Date:	Fri, 25 Jan 2013 13:01:51 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Thomas Jarosch <thomas.jarosch@...ra2net.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure

Em Fri, Jan 25, 2013 at 11:22:17AM +0100, Thomas Jarosch escreveu:
> cppcheck reported:
> [util/header.c:983]: (error) Used file that is not opened.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@...ra2net.com>
> ---
>  tools/perf/util/header.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 7b24cf3..30745c2 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
>  	}
>  
>  	fclose(fp);
> +	fp = NULL;

Ok, but what is the behaviour of fclose(NULL)? Is it defined?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/