linux-kernel - Re: [tip:x86/platform] x86: Add TS-5500 platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1344460915.280514.1359132048723.JavaMail.root@mail.savoirfairelinux.com>
Date:	Fri, 25 Jan 2013 11:40:48 -0500 (EST)
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-tip-commits@...r.kernel.org, hpa@...or.com,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
	tglx@...utronix.de
Subject: Re: [tip:x86/platform] x86: Add TS-5500 platform support

Hi Ingo,

> This patch still appears to have some problems with certain
> (rare) LEDS .config variations:
> 
>  arch/x86/built-in.o: In function `ts5500_init':
>  ts5500.c:(.init.text+0xdae6): undefined reference to
>  `led_classdev_register'
> 
> Config attached.
> 
> Please fix & resend.

I think the attached config might not be the right one. This issue
happens when the ts5500 support is selected (CONFIG_TS5500=y) but
the LED class (CONFIG_NEW_LEDS and CONFIG_LEDS_CLASS) is not.

Thanks for pointing this out.
The following patch below solves this issue. Is it ok, or should
I resend to whole board support patch?

Thanks,
Vivien

--------


diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index df5815e..9394759 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2191,6 +2191,8 @@ config TS5500
        bool "Technologic Systems TS-5500 platform support"
        depends on MELAN
        select CHECK_SIGNATURE
+       select NEW_LEDS
+       select LEDS_CLASS
        ---help---
          This option enables system support for the Technologic Systems TS-5500.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/