linux-kernel - Re: [tip:x86/platform] x86: Add TS-5500 platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130125183825.GC31022@gmail.com>
Date:	Fri, 25 Jan 2013 19:38:25 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	linux-tip-commits@...r.kernel.org, hpa@...or.com,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
	tglx@...utronix.de
Subject: Re: [tip:x86/platform] x86: Add TS-5500 platform support


* Vivien Didelot <vivien.didelot@...oirfairelinux.com> wrote:

> Hi Ingo,
> 
> > This patch still appears to have some problems with certain
> > (rare) LEDS .config variations:
> > 
> >  arch/x86/built-in.o: In function `ts5500_init':
> >  ts5500.c:(.init.text+0xdae6): undefined reference to
> >  `led_classdev_register'
> > 
> > Config attached.
> > 
> > Please fix & resend.
> 
> I think the attached config might not be the right one. [...]

Hm, yes - sorry. The failure happened on a testbox and I might 
have misplaced the config.

> [...] This issue happens when the ts5500 support is selected 
> (CONFIG_TS5500=y) but the LED class (CONFIG_NEW_LEDS and 
> CONFIG_LEDS_CLASS) is not.
> 
> Thanks for pointing this out.
> The following patch below solves this issue. Is it ok, or should
> I resend to whole board support patch?

This one's OK, I'll resurrect the old one and amend it with your 
delta fix.

Thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/