linux-kernel - Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130125174442.GA32333@kroah.com>
Date:	Fri, 25 Jan 2013 09:44:42 -0800
From:	Greg KH <greg@...ah.com>
To:	fangxiaozhi 00110321 <fangxiaozhi@...wei.com>
Cc:	Sergei Shtylyov <sshtylyov@...sta.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, zihan@...wei.com, Lin.Lei@...wei.com,
	neil.yi@...wei.com, wangyuhua@...wei.com, huqiao36@...wei.com,
	balbi@...com, mdharm-usb@...-eyed-alien.net,
	sebastian@...akpoint.cc
Subject: Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match
 rules

On Fri, Jan 25, 2013 at 04:18:34PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 25-01-2013 6:44, fangxiaozhi 00110321 wrote:
> 
> >From: fangxiaozhi <huananhu@...wei.com>
> 
> >1. Define a new macro for USB storage match rules:
> >     matching with Vendor ID and interface descriptors.
> 
> >Signed-off-by: fangxiaozhi <huananhu@...wei.com>
> >--------------------------------------------------------------------
> >
> >  diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usb.c linux-3.8-rc4/drivers/usb/storage/usb.c
> >--- linux-3.8-rc4_orig/drivers/usb/storage/usb.c 2013-01-22 14:12:42.595238727 +0800
> >+++ linux-3.8-rc4/drivers/usb/storage/usb.c 2013-01-22 14:16:01.398250305 +0800
> >@@ -120,6 +120,17 @@ MODULE_PARM_DESC(quirks, "supplemental l
> >   .useTransport = use_transport, \
> >  }
> >
> >+#define UNUSUAL_VENDOR_INTF(idVendor, cl, sc, pr, \
> >+         vendor_name, product_name, use_protocol, use_transport, \
> >+         init_function, Flags) \
> >+{ \
> >+ .vendorName = vendor_name, \
> >+ .productName = product_name, \
> >+ .useProtocol = use_protocol, \
> >+ .useTransport = use_transport, \
> >+ .initFunction = init_function, \
> >+}
> 
>   Shouldn't the field initilaizers be indented with tab, not space?

Yes it must.  fangxiaozhi, please always run your patches through the
scripts/checkpatch.pl tool before sending them out (note, you will have
to ignore the CamelCase warnings your patch produces, but not the other
ones.)

Please do that on both of these patches and resend them.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/