linux-kernel - RE: [PATCH 1/2]linux-usb:Define a new macro for USB storage match rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <910F9D9E13B84F4C8FA771DC9BDE99F32702A880@szxeml546-mbx.china.huawei.com>
Date:	Sat, 26 Jan 2013 01:39:50 +0000
From:	"Fangxiaozhi (Franko)" <fangxiaozhi@...wei.com>
To:	Greg KH <greg@...ah.com>
CC:	Sergei Shtylyov <sshtylyov@...sta.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Xueguiying (Zihan)" <zihan.xue@...wei.com>,
	"Linlei (Lei Lin)" <lei.lin@...wei.com>,
	"Yili (Neil)" <neil.yi@...wei.com>,
	"Wangyuhua (Roger, Credit)" <wangyuhua@...wei.com>,
	"Huqiao (C)" <huqiao36@...wei.com>, "balbi@...com" <balbi@...com>,
	"mdharm-usb@...-eyed-alien.net" <mdharm-usb@...-eyed-alien.net>,
	"sebastian@...akpoint.cc" <sebastian@...akpoint.cc>
Subject: RE: [PATCH 1/2]linux-usb:Define a new macro for USB storage match
 rules



> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: Saturday, January 26, 2013 1:45 AM
> To: Fangxiaozhi (Franko)
> Cc: Sergei Shtylyov; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org;
> Xueguiying (Zihan); Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit);
> Huqiao (C); balbi@...com; mdharm-usb@...-eyed-alien.net;
> sebastian@...akpoint.cc
> Subject: Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match
> rules
> 
> On Fri, Jan 25, 2013 at 04:18:34PM +0400, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 25-01-2013 6:44, fangxiaozhi 00110321 wrote:
> >
> > >From: fangxiaozhi <huananhu@...wei.com>
> >
> > >1. Define a new macro for USB storage match rules:
> > >     matching with Vendor ID and interface descriptors.
> >
> > >Signed-off-by: fangxiaozhi <huananhu@...wei.com>
> > >--------------------------------------------------------------------
> > >
> > >  diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usb.c
> > >linux-3.8-rc4/drivers/usb/storage/usb.c
> > >--- linux-3.8-rc4_orig/drivers/usb/storage/usb.c 2013-01-22
> > >14:12:42.595238727 +0800
> > >+++ linux-3.8-rc4/drivers/usb/storage/usb.c 2013-01-22
> > >+++ 14:16:01.398250305 +0800
> > >@@ -120,6 +120,17 @@ MODULE_PARM_DESC(quirks, "supplemental l
> > >   .useTransport = use_transport, \
> > >  }
> > >
> > >+#define UNUSUAL_VENDOR_INTF(idVendor, cl, sc, pr, \
> > >+         vendor_name, product_name, use_protocol, use_transport, \
> > >+         init_function, Flags) \
> > >+{ \
> > >+ .vendorName = vendor_name, \
> > >+ .productName = product_name, \
> > >+ .useProtocol = use_protocol, \
> > >+ .useTransport = use_transport, \
> > >+ .initFunction = init_function, \
> > >+}
> >
> >   Shouldn't the field initilaizers be indented with tab, not space?
> 
> Yes it must.  fangxiaozhi, please always run your patches through the
> scripts/checkpatch.pl tool before sending them out (note, you will have to
> ignore the CamelCase warnings your patch produces, but not the other
> ones.)
> 
-----What's wrong with it?
-----I have checked the patches with scripts/checkpatch.pl before sending.
-----There is no other warning or error in my patches except CamelCase warnings.
-----So what's wrong now?

> Please do that on both of these patches and resend them.
> 
> thanks,
> 
> greg k-h