linux-kernel - RE: [PATCH 12/19] pinctrl: exynos: don't mark probing functions as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jan 2013 09:51:39 -0800
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Arnd Bergmann' <arnd@...db.de>,
	linux-arm-kernel@...t.infradead.org
Cc:	linux-kernel@...r.kernel.org,
	'Linus Walleij' <linus.walleij@...aro.org>,
	'Tomasz Figa' <t.figa@...sung.com>
Subject: RE: [PATCH 12/19] pinctrl: exynos: don't mark probing functions as
 __init

Arnd Bergmann wrote:
> 
> Functions called from a driver probe() method must not be
> marked __init, because they may get called after the
> init phase is done, when the device shows up late, or
> because of deferred probing.
> 
> Without this patch, building exynos_defconfig results in
> multiple warnings like:
> 
> WARNING: drivers/pinctrl/built-in.o(.text+0x51bc): Section mismatch in
> reference from the function exynos5440_pinctrl_probe() to the
> function .init.text:exynos5440_gpiolib_register()
> The function exynos5440_pinctrl_probe() references
> the function __init exynos5440_gpiolib_register().
> This is often because exynos5440_pinctrl_probe lacks a __init
> annotation or the annotation of exynos5440_gpiolib_register is wrong.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Tomasz Figa <t.figa@...sung.com>
> Cc: Kukjin Kim <kgene.kim@...sung.com>

Acked-by: Kukjin Kim <kgene.kim@...sung.com>

Thanks.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/