linux-kernel - Re: [PATCH 3/11] ksm: trivial tidyups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130128151119.b74d0150.akpm@linux-foundation.org>
Date:	Mon, 28 Jan 2013 15:11:19 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	Petr Holasek <pholasek@...hat.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Izik Eidus <izik.eidus@...ellosystems.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 3/11] ksm: trivial tidyups

On Fri, 25 Jan 2013 17:58:11 -0800 (PST)
Hugh Dickins <hughd@...gle.com> wrote:

> +#ifdef CONFIG_NUMA
> +#define NUMA(x)		(x)
> +#define DO_NUMA(x)	(x)

Did we consider

	#define DO_NUMA do { (x) } while (0)

?

That could avoid some nasty config-dependent compilation issues.

> +#else
> +#define NUMA(x)		(0)
> +#define DO_NUMA(x)	do { } while (0)
> +#endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/