linux-kernel - Re: [PATCH 1/1] USB: option: add support for Telit LE920

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87txpznkog.fsf@nemi.mork.no>
Date:	Wed, 30 Jan 2013 09:23:43 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Daniele Palmas <dnlplm@...il.com>
Cc:	Dan Williams <dcbw@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matthias Urlichs <smurf@...rf.noris.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] USB: option: add support for Telit LE920

Daniele Palmas <dnlplm@...il.com> writes:

> The output of lsusb for interface #1 is the following:
>
> Interface Descriptor:
>       bLength                 9
>       bDescriptorType         4
>       bInterfaceNumber        1
>       bAlternateSetting       0
>       bNumEndpoints           2
>       bInterfaceClass       255 Vendor Specific Class
>       bInterfaceSubClass     66
>       bInterfaceProtocol      1
>       iInterface              0
>
> It should be an adb device, so probably it is not needed to blacklist
> it. Should I resend a new patch with only interface #5 reserved?

You could have used USB_DEVICE_AND_INTERFACE_INFO() matching on all
ff/ff/ff to avoid blacklisting the adb interface, but IMHO the patch is
fine as it is.

This being an Android device raises another question though: Are these
interface numbers static?  I assume you can e.g. disable adb?  What
happens to the descriptors then?  Does the device change pid, or are the
interfaces renumbered?


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/