linux-kernel - Re: [PATCH 1/1] USB: option: add support for Telit LE920

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGRyCJFgk5bYgY28tPo3UD8CvAM0cAVsY6bXkK=KEh4HhPy2_A@mail.gmail.com>
Date:	Wed, 30 Jan 2013 10:23:57 +0100
From:	Daniele Palmas <dnlplm@...il.com>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	Dan Williams <dcbw@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Matthias Urlichs <smurf@...rf.noris.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] USB: option: add support for Telit LE920

2013/1/30 Bjørn Mork <bjorn@...k.no>:
> Daniele Palmas <dnlplm@...il.com> writes:
>
>> The output of lsusb for interface #1 is the following:
>>
>> Interface Descriptor:
>>       bLength                 9
>>       bDescriptorType         4
>>       bInterfaceNumber        1
>>       bAlternateSetting       0
>>       bNumEndpoints           2
>>       bInterfaceClass       255 Vendor Specific Class
>>       bInterfaceSubClass     66
>>       bInterfaceProtocol      1
>>       iInterface              0
>>
>> It should be an adb device, so probably it is not needed to blacklist
>> it. Should I resend a new patch with only interface #5 reserved?
>
> You could have used USB_DEVICE_AND_INTERFACE_INFO() matching on all
> ff/ff/ff to avoid blacklisting the adb interface, but IMHO the patch is
> fine as it is.
>

Thanks, next time I'll follow that way.

> This being an Android device raises another question though: Are these
> interface numbers static?  I assume you can e.g. disable adb?  What
> happens to the descriptors then?  Does the device change pid, or are the
> interfaces renumbered?
>

This is the device:

http://www.telit.com/en/products/lte.php?p_id=421&p_ac=show&p=130

It is not an Android device, but an AT command based modem. I don't
really know why there is an adb interface, but I am quite sure that
you cannot disable it and the interface numbers should be static.

However, if I find that this is not true, I will take care of sending
a new set of patches for addressing the issue.

Regards,
Daniele
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/