linux-kernel - Re: [PATCH 02/25] perf top: Delete maps on exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510AB468.8020904@gmail.com>
Date:	Thu, 31 Jan 2013 11:14:00 -0700
From:	David Ahern <dsahern@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
CC:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 02/25] perf top: Delete maps on exit

On 1/31/13 10:25 AM, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
>
> Removing one more memory leak found with valgrind.

If you are spending time one memory consumption by perf-top one thing to 
look at is handling of terminated threads. Currently, terminated threads 
are stuck onto the dead_threads list and only cleaned up when perf 
terminates (perf_session__delete_dead_threads).

Since the thread entries can still be referenced in hists perhaps a 
refcnt is needed that indicates when the threads can be deleted. From 
there regular calls to perf_session__delete_dead_threads can be made. I 
needed to add a regular call to that function in my perf daemon to keep 
memory usage stable - but then I don't have lingering references.

A lot of work yes but will be needed if there is to be an official 
libperf.so that apps can leverage.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/