linux-kernel - Re: [PATCH 3/3] nsproxy: remove duplicate task_cred_xxx for user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Jan 2013 18:16:55 +0000
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	Yuanhan Liu <yuanhan.liu@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Serge Hallyn <serge.hallyn@...onical.com>
Subject: Re: [PATCH 3/3] nsproxy: remove duplicate task_cred_xxx for user_ns

Quoting Yuanhan Liu (yuanhan.liu@...ux.intel.com):
> We can use user_ns, which is also assigned from task_cred_xxx(tsk,
> user_ns), at the beginning of copy_namespaces().
> 
> Cc: Serge Hallyn <serge.hallyn@...onical.com>

Acked-by: Serge Hallyn <serge.hallyn@...onical.com>

> Signed-off-by: Yuanhan Liu <yuanhan.liu@...ux.intel.com>
> ---
>  kernel/nsproxy.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
> index 78e2ecb..b781e66 100644
> --- a/kernel/nsproxy.c
> +++ b/kernel/nsproxy.c
> @@ -153,8 +153,7 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk)
>  		goto out;
>  	}
>  
> -	new_ns = create_new_namespaces(flags, tsk,
> -				       task_cred_xxx(tsk, user_ns), tsk->fs);
> +	new_ns = create_new_namespaces(flags, tsk, user_ns, tsk->fs);
>  	if (IS_ERR(new_ns)) {
>  		err = PTR_ERR(new_ns);
>  		goto out;
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/