linux-kernel - Re: [PATCH 04/12] perf, x86: Support the TSX intx/intx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130201101628.GB23061@gmail.com>
Date:	Fri, 1 Feb 2013 11:16:28 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	akpm@...ux-foundation.org, acme@...hat.com, eranian@...gle.com,
	jolsa@...hat.com, namhyung@...nel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 04/12] perf, x86: Support the TSX intx/intx_cp qualifiers
 v3

* Andi Kleen <andi@...stfloor.org> wrote:

> From: Andi Kleen <ak@...ux.intel.com>
> 
> Implement the TSX transaction and checkpointed transaction qualifiers for
> Haswell. This allows e.g. to profile the number of cycles in transactions.
> 
> The checkpointed qualifier requires forcing the event to
> counter 2, implement this with a custom constraint for Haswell.
> 
> Also add sysfs format attributes for intx/intx_cp

The series is getting smaller, but you still included this patch 
I pointed out in my last review, which unnecessary increases the 
size of the initial hw support series by adding Haswell-specific 
transaction profiling features.

As requested before, please keep those in a completely separate 
series so that minimal support can be merged upstream. This is 
how we always did new hardware support in the past, in iterative 
steps, and we are not going to make an exception for you.

I find it pretty counterproductive that you have ignored my 
previous series structure request. Every unnecessary delay you 
cause here delays upstream profiling support for Haswell CPUs.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/