linux-kernel - Re: [ 06/89] powerpc/book3e: Disable interrupt after preempt_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1359896460.29976.0.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 03 Feb 2013 14:01:00 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Tiejun Chen <tiejun.chen@...driver.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 06/89] powerpc/book3e: Disable interrupt after
 preempt_schedule_irq

On Fri, 2013-02-01 at 14:07 +0100, Greg Kroah-Hartman wrote:
> 3.7-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Tiejun Chen <tiejun.chen@...driver.com>
> 
> commit 572177d7c77db1981ba2563e01478126482c43bc upstream.
> 
> In preempt case current arch_local_irq_restore() from
> preempt_schedule_irq() may enable hard interrupt but we really
> should disable interrupts when we return from the interrupt,
> and so that we don't get interrupted after loading SRR0/1.
> 
> Signed-off-by: Tiejun Chen <tiejun.chen@...driver.com>
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
[...]

Is this needed for any earlier kernel versions?

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                           - Albert Einstein

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)