linux-kernel - Re: [PATCH 1/2] arm: pxa: tosa: do not use gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN1soZxOX24QCYOTXmVOmNGu-+ShUPaBScxh38C=p7-v_2OZnw@mail.gmail.com>
Date:	Sun, 3 Feb 2013 08:29:03 +0800
From:	Haojian Zhuang <haojian.zhuang@...il.com>
To:	Alexandre Courbot <acourbot@...dia.com>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Dirk Opfer <dirk@...er-online.de>,
	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>,
	Eric Miao <eric.y.miao@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, linux-arch@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	gnurou@...il.com
Subject: Re: [PATCH 1/2] arm: pxa: tosa: do not use gpiochip_reserve()

On Sat, Feb 2, 2013 at 10:44 PM, Alexandre Courbot <acourbot@...dia.com> wrote:
> GPIO address space reservation during early platform initialization is
> not needed anymore for Tosa. Remove the calls to gpiochip_reserve()
> which is due to be removed.
>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
>  arch/arm/mach-pxa/tosa.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/tosa.c b/arch/arm/mach-pxa/tosa.c
> index 9e7998d..3d91d2e 100644
> --- a/arch/arm/mach-pxa/tosa.c
> +++ b/arch/arm/mach-pxa/tosa.c
> @@ -927,8 +927,6 @@ static void tosa_restart(char mode, const char *cmd)
>
>  static void __init tosa_init(void)
>  {
> -       int dummy;
> -
>         pxa2xx_mfp_config(ARRAY_AND_SIZE(tosa_pin_config));
>
>         pxa_set_ffuart_info(NULL);
> @@ -947,10 +945,6 @@ static void __init tosa_init(void)
>         /* enable batt_fault */
>         PMCR = 0x01;
>
> -       dummy = gpiochip_reserve(TOSA_SCOOP_GPIO_BASE, 12);
> -       dummy = gpiochip_reserve(TOSA_SCOOP_JC_GPIO_BASE, 12);
> -       dummy = gpiochip_reserve(TOSA_TC6393XB_GPIO_BASE, 16);
> -
>         pxa_set_mci_info(&tosa_mci_platform_data);
>         pxa_set_ficp_info(&tosa_ficp_platform_data);
>         pxa_set_i2c_info(NULL);
> --
> 1.8.1.1
>

Acked-by: Haojian Zhuang <haojian.zhuang@...il.com>

Linus,

Could you help to merge this patch into your gpio git tree? I think
that both of them should go through one git tree.

Regards
Haojian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/