linux-kernel - Re: [PATCH 1/3] hid: Add report descriptor for Logitech Driving Force wheel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eda86cfd7fd3f5878ef00e3e8a9de1c6.squirrel@www.mungewell.org>
Date:	Sat, 2 Feb 2013 19:30:23 -0500
From:	simon@...gewell.org
To:	"Paul Sbarra" <sbarra.paul@...il.com>
Cc:	jkosina@...e.cz, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, "Paul Sbarra" <sbarra.paul@...il.com>
Subject: Re: [PATCH 1/3] hid: Add report descriptor for Logitech Driving
 Force wheel

> This is the original report descriptor as reported by lsusb -vd 046d:c294.
>
> Signed-off-by: Paul Sbarra <sbarra.paul@...il.com>
> ---
>  drivers/hid/hid-lg.c | 84
> ++++++++++++++++++++++++++++++++++++++++++++++++----

>  	switch (hdev->product) {
> +	case USB_DEVICE_ID_LOGITECH_WHEEL:
> +		if (*rsize == DF_RDESC_ORIG_SIZE) {
> +			hid_info(hdev,
> +				"fixing up Logitech Driving Force report descriptor\n");
> +			rdesc = df_rdesc_fixed;
> +			*rsize = sizeof(df_rdesc_fixed);
> +		}
> +		break;
> +
>  	case USB_DEVICE_ID_LOGITECH_DFP_WHEEL:
>  		if (*rsize == DFP_RDESC_ORIG_SIZE) {
>  			hid_info(hdev,
> --


Hi Paul,
I'm not following as to why you are patching the descriptor for the DFP,
my understanding is that this is fully supported at the moment (as
USB_DEVICE_ID_LOGITECH_DFP_WHEEL in the line after your patch).

Perhaps you have a different revision. Can you please forward a 'lsusb
-vv' to we can compare.

I have attached the one from my DPF.
--
simon@...kie:~/speed-dreams-2.0$ lsusb
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 003: ID 5986:01a6 Acer, Inc Lenovo Integrated Webcam
Bus 003 Device 002: ID 0a5c:217f Broadcom Corp. Bluetooth Controller
Bus 003 Device 003: ID 046d:c294 Logitech, Inc. Driving Force
--

Thanks,
Simon.
View attachment "lsusb_vv.txt" of type "text/plain" (2288 bytes)