linux-kernel - Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFp+6iEEtq=ncTb9pWQSMpvW2S-eRpSPBBYM2SnUmmvVaA=Zvg@mail.gmail.com>
Date:	Mon, 4 Feb 2013 16:45:03 +0530
From:	Vivek Gautam <gautamvivek1987@...il.com>
To:	Kukjin Kim <kgene.kim@...sung.com>
Cc:	Tomasz Figa <tomasz.figa@...il.com>,
	Vivek Gautam <gautam.vivek@...sung.com>, jg1.han@...sung.com,
	linux-samsung-soc@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

Hi Kukjin,


On Fri, Feb 1, 2013 at 3:56 AM, Kukjin Kim <kgene.kim@...sung.com> wrote:
> Tomasz Figa wrote:
>>
>> Hi Vivek,
>
> [...]
>
>> > +   usb@...20000 {
>> > +           compatible = "samsung,exynos4210-ohci";
>> > +           reg = <0x12120000 0x100>;
>> > +           interrupts = <0 71 0>;
>>
>> For Samsung platforms we decided per board enabling of nodes and so this
>> node should also contain:
>>
>>               status = "disabled";
>>
>> while in dts file of board using ohci there would be an overriding entry:
>>
>>       usb@...20000 {
>>               status = "okay";
>>       };
>>
>> I know that Exynos5250 has not been yet converted into this convention,
>> but using it when adding new devices will simplify the process.
>>
> Well, I have another opinion on this...
>
> Let's see, yeah, we are using following method in EXYNOS4 DT...
> - disabling IPs in SoC DT source and enabling IPs in board DT source
>
> But as I said, in EXYNOS5440 DT, I want to use following, because most of
> them should be enabled/used.
> - enabling IPs in SoC DT source and no need enabling in board DT source.
>
> I mean, it depends on each SoC's situation.
>

So, since USB 2.0 (EHCI/OHCI) shall be always enabled on almost all the boards,
so we shall keep it enabled in SOC DT source.

In that case following patches can be picked for a merge:
[PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver
http://www.mail-archive.com/linux-usb@vger.kernel.org/msg12330.html

[PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver
http://www.mail-archive.com/linux-usb@vger.kernel.org/msg12266.html

These will enable EHCI and OHCI support on exynos5250.
Please let me know if you want me to resend them. ;-)


-- 
Thanks & Regards
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/