linux-kernel - Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130204171031.GK27963@mtj.dyndns.org>
Date:	Mon, 4 Feb 2013 09:10:31 -0800
From:	Tejun Heo <tj@...nel.org>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	rusty@...tcorp.com.au, skinsbursky@...allels.com,
	ebiederm@...ssion.com, jmorris@...ei.org, axboe@...nel.dk
Subject: Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

Hey,

On Sun, Feb 03, 2013 at 07:15:58PM -0500, J. Bruce Fields wrote:
> On Sun, Feb 03, 2013 at 12:02:41PM -0500, J. Bruce Fields wrote:
> > On Sat, Feb 02, 2013 at 05:20:01PM -0800, Tejun Heo wrote:
> > > * Bruce, I couldn't convert nfsd.  Can you please help?  More on it
> > >   later.
> > ...
> > > I converted all in-kernel users except nfsd and staging drivers.  nfsd
> > > splits preloading and actual id allocation in a way that per-cpu
> > > preloading can't be used.  I couldn't follow the control flow to
> > > verify whether the current code is correct either.  I think the best
> > > way would be allocating ID upfront without installing the handle and
> > > then later using idr_replace() to install the pointer when the ID
> > > actually gets used.  Bruce, would something like that be possible?
> > 
> > Actually, I'm not even sure if that's necessary, we can probably just
> > do it all at the start.
> > 
> > I'll try to have a patch doing that tomorrow.
> 
> So, something like this.

Yeah, that should be easily convertable to the new interface.  How
should we route these changes?  Your patch can go through the usual
nfs channel and the conversion and deprecation patches can be held off
until after -rc1.  Does that sound okay?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/