linux-kernel - Re: [patch] config: fix make kvmconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130204191157.GA14837@gmail.com>
Date:	Mon, 4 Feb 2013 20:11:57 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	Sasha Levin <levinsasha928@...il.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Michal Marek <mmarek@...e.cz>,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] config: fix make kvmconfig


* David Rientjes <rientjes@...gle.com> wrote:

> On Mon, 4 Feb 2013, Ingo Molnar wrote:
> 
> > >  arch/x86/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > > index 6979498..f9459b3 100644
> > > --- a/arch/x86/Kconfig
> > > +++ b/arch/x86/Kconfig
> > > @@ -606,6 +606,7 @@ config KVMTOOL_TEST_ENABLE
> > >  	select NETWORK_FILESYSTEMS
> > >  	select INET
> > >  	select EXPERIMENTAL
> > > +	select TTY
> > >  	select SERIAL_8250
> > >  	select SERIAL_8250_CONSOLE
> > >  	select IP_PNP
> > 
> > There's no 'config TTY' in the kernel AFAICS.
> > 
> 
> It's added in linux-next by 4f73bc4dd3e8 ("tty: Added a 
> CONFIG_TTY option to allow removal of TTY").
> 
> Adding Greg to the cc to figure out which tree this should be 
> merged through.  Greg, please find the patch inline.
> 
> The better alternative would be to remove KVMTOOL_TEST_ENABLE 
> entirely since it has been sitting in linux-next for over a 
> year, Linus has said he won't pull it, and it consistently 
> needs updates both inside and outside of Pekka's tree.

Looks like this is a merge artifact then. I'll fix it once 
Greg's changes hit upstream.

'make kvmconfig' generally works fine in my tree, and I'm using 
it for testing on an almost daily basis.

It's never run by default and you have to actively use it, so it 
cannot regress any existing code AFAICS.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/