linux-kernel - Re: [patch] config: fix make kvmconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130204191334.GB14837@gmail.com>
Date:	Mon, 4 Feb 2013 20:13:34 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	David Rientjes <rientjes@...gle.com>,
	Pekka Enberg <penberg@...nel.org>,
	Sasha Levin <levinsasha928@...il.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Michal Marek <mmarek@...e.cz>,
	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] config: fix make kvmconfig


* Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Mon, Feb 04, 2013 at 10:57:35AM -0800, David Rientjes wrote:
> > On Mon, 4 Feb 2013, Ingo Molnar wrote:
> > 
> > > >  arch/x86/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > > > index 6979498..f9459b3 100644
> > > > --- a/arch/x86/Kconfig
> > > > +++ b/arch/x86/Kconfig
> > > > @@ -606,6 +606,7 @@ config KVMTOOL_TEST_ENABLE
> > > >  	select NETWORK_FILESYSTEMS
> > > >  	select INET
> > > >  	select EXPERIMENTAL
> > > > +	select TTY
> > > >  	select SERIAL_8250
> > > >  	select SERIAL_8250_CONSOLE
> > > >  	select IP_PNP
> > > 
> > > There's no 'config TTY' in the kernel AFAICS.
> > > 
> > 
> > It's added in linux-next by 4f73bc4dd3e8 ("tty: Added a CONFIG_TTY option 
> > to allow removal of TTY").
> > 
> > Adding Greg to the cc to figure out which tree this should be merged 
> > through.  Greg, please find the patch inline.
> 
> Ideally it would go through my tree, but it can't because 
> KVMTOOL_TEST_ENABLE isn't in my tree :(
> 
> I suggest just adding it to whatever tree this change is in, 
> it doesn't "hurt" to enable a config option that isn't in the 
> tree at the moment, right?  Or will Kconfig complain about it?

Yeah, that's a good idea - I think Pekka can apply that change 
just fine to help anyone doing merges - I don't think kconfig 
treats it as a fatal error.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/