linux-kernel - Re: [PATCH 05/73] ARM: ux500: Vsmps3 controlled by SysClkReq1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYWZOa=bbJYpG7owxVJXxPq5sx7jHmo5UpRe8pmPGYKMQ@mail.gmail.com>
Date:	Mon, 4 Feb 2013 22:21:36 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
	Bengt Jonsson <bengt.g.jonsson@...ricsson.com>,
	Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH 05/73] ARM: ux500: Vsmps3 controlled by SysClkReq1

On Mon, Feb 4, 2013 at 8:37 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> On Mon, Feb 04, 2013 at 11:53:20AM +0000, Lee Jones wrote:
>> Vsmps3 is put in HW control by SysClkReq1 at init. The
>> corresponding settings in suspend-force are removed.
>
> So, I've applied the patches up to here though I'm still reallly unhappy
> with this code - it seems clear from the comments that a lot of this
> stuff should be using regulator constraints to initialise.  It would be
> good to move this stuff over to use the framework.

So I've briefly discussed it with Bengt at one point.

Basically what the ABx500 PMICs have is a sort of
logic network or table that you can set up to respond
autonomously to different "SysClkReq" signals.

Originally these signals were intended for gating
and ungating clocks but they are basically a boolean
"enable that resource I want" signals.

So it is not even primarily used for clocks, but
regulators. It will for example power them off/on
on that signal but also more elaborate stuff I think.

What is needed is some way to model that
electronic relationship into both the regulator
and clock subsystems (Ulf Hansson is working on
the ABx500 clocks as we speak.)

Maybe the actual place to have it would be
somewhere like drivers/mfd/ab8500-core.c.

Have you seen similar stuff in other PMICs?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/