linux-kernel - Re: [PATCH 03/13] workqueue: don't set work cwq until we queued it on pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130204212808.GC27963@mtj.dyndns.org>
Date:	Mon, 4 Feb 2013 13:28:08 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/13] workqueue: don't set work cwq until we queued it
 on pool

Hello, again.

On Fri, Feb 01, 2013 at 02:41:26AM +0800, Lai Jiangshan wrote:
> @@ -110,6 +110,7 @@ struct delayed_work {
>  	struct work_struct work;
>  	struct timer_list timer;
>  	int cpu;
> +	struct workqueue_struct *wq;

Can't we just replace delayed_work->cpu with delayed_work->cwq?  That
way, we don't enlarge delayed_work while encoding both wq and cpu in
delayed_work proper.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/