linux-kernel - Re: [PATCH 0/3] mm: rename confusing function names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5111B318.9020204@cn.fujitsu.com>
Date:	Wed, 06 Feb 2013 09:34:16 +0800
From:	Zhang Yanfei <zhangyanfei@...fujitsu.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Johannes Weiner <hannes@...xchg.org>,
	Zhang Yanfei <zhangyanfei.yes@...il.com>,
	Linux MM <linux-mm@...ck.org>, mgorman@...e.de,
	minchan@...nel.org, kamezawa.hiroyu@...fujitsu.com,
	m.szyprowski@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] mm: rename confusing function names

于 2013年02月06日 09:20, Andrew Morton 写道:
> On Wed, 06 Feb 2013 09:06:05 +0800
> Zhang Yanfei <zhangyanfei@...fujitsu.com> wrote:
> 
>> So could I rename the functions to the names like
>> nr_available_buffer_high_pages
>> And accurately document them with code comments just as you suggested.
> 
> gee.  "available" implies "available for you to allocate".  It has the
> same problem as "free".
> 
> And "buffer" shouldn't be there - that's a reflection of the fact
> that buffer_head payloads are not allocated from highmem.  An archaic
> irrelevant thing.
> 
> Seriously, first let's write down the descriptions of what these
> functions *do*.  Then choose nice names which abbreviate that.
> 

OK, I will try to do this.

> 
> 
> hm,
> 
> static unsigned int nr_free_zone_pages(int offset)
> {
> 	...
> 	unsigned int sum = 0;
> 	...
> 	return sum;
> }
> 
> How long will it be until these things start exploding from
> sums-of-zones which exceed 16TB?  
> 

You mean overflow? Hmm.. it might happens. Change the sum to
unsigned long is ok?

Thanks
Zhang Yanfei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/