linux-kernel - Re: [PATCH 1/7] cpufreq: Don't remove sysfs link for policy->cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOh2x=n4NJhM3_JBpbOgbuOiFkh_fB+cshYcvCeBxUphXLNdRA@mail.gmail.com>
Date:	Wed, 6 Feb 2013 07:12:10 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	dirk.brandewie@...il.com
Cc:	linux-kernel@...r.kernel.org, cpufreq@...r.kernel.org
Subject: Re: [PATCH 1/7] cpufreq: Don't remove sysfs link for policy->cpu

On Tue, Feb 5, 2013 at 11:54 PM,  <dirk.brandewie@...il.com> wrote:
> From: Viresh Kumar <viresh.kumar@...aro.org>
>
> "cpufreq" directory in policy->cpu is never created using sysfs_create_link(),
> but using kobject_init_and_add(). And so we shouldn't call sysfs_remove_link()
> for policy->cpu(). sysfs stuff for policy->cpu is automatically removed when we
> call kobject_put() for dying policy.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> Tested-by: Dirk Brandewie <dirk.brandewie@...il.com>

Its already included by Rafael, don't include it in your next version:

commit 73bf0fc2b03d1f4fdada0ec430dc20bfb089cfd5
Author: Viresh Kumar <viresh.kumar@...aro.org>
Date:   Tue Feb 5 22:21:14 2013 +0100

    cpufreq: Don't remove sysfs link for policy->cpu

    "cpufreq" directory in policy->cpu is never created using
    sysfs_create_link(), but using kobject_init_and_add(). And so we
    shouldn't call sysfs_remove_link() for policy->cpu().  sysfs stuff
    for policy->cpu is automatically removed when we call kobject_put()
    for dying policy.

    Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
    Tested-by: Dirk Brandewie <dirk.brandewie@...il.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/