linux-kernel - Re: [PATCH 3/8] ARM: dts: omap: Add usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51134A5F.1090707@ti.com>
Date:	Thu, 7 Feb 2013 12:01:59 +0530
From:	kishon <kishon@...com>
To:	Rajendra Nayak <rnayak@...com>
CC:	<b-cousson@...com>, <tony@...mide.com>, <linux@....linux.org.uk>,
	<rob.herring@...xeda.com>, <rob@...dley.net>, <balbi@...com>,
	<linux-usb@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<devicetree-discuss@...ts.ozlabs.org>, <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3/8] ARM: dts: omap: Add usb_otg and glue data

Hi,

On Thursday 07 February 2013 11:51 AM, Rajendra Nayak wrote:
> []...
>
>>
>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt
>> b/Documentation/devicetree/bindings/usb/omap-usb.txt
>> index 29a043e..4688265 100644
>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
>> @@ -15,6 +15,7 @@ OMAP MUSB GLUE
>>      represents PERIPHERAL.
>>    - power : Should be "50". This signifies the controller can supply
>> upto
>>      100mA when operating in host mode.
>> + - usb-phy : the phandle for the PHY device
>>
>>   SOC specific device node entry
>>   usb_otg_hs: usb_otg_hs@...ab000 {
>> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts
>> b/arch/arm/boot/dts/omap3-beagle-xm.dts
>> index 3705a81..cb07583 100644
>> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
>> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
>> @@ -107,3 +107,9 @@
>>        */
>>       ti,pulldowns = <0x03a1c4>;
>>   };
>> +
>> +&usb_otg_hs {
>> +    interface_type = <0>;
>> +    mode = <3>;
>> +    power = <50>;
>> +};
>> diff --git a/arch/arm/boot/dts/omap3-evm.dts
>> b/arch/arm/boot/dts/omap3-evm.dts
>> index e8ba1c2..afb9ba9 100644
>> --- a/arch/arm/boot/dts/omap3-evm.dts
>> +++ b/arch/arm/boot/dts/omap3-evm.dts
>> @@ -59,3 +59,9 @@
>>   &twl_gpio {
>>       ti,use-leds;
>>   };
>> +
>> +&usb_otg_hs {
>> +    interface_type = <0>;
>> +    mode = <3>;
>> +    power = <50>;
>> +};
>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi
>> b/arch/arm/boot/dts/omap3-overo.dtsi
>> index 89808ce..4b3d157 100644
>> --- a/arch/arm/boot/dts/omap3-overo.dtsi
>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
>> @@ -55,3 +55,9 @@
>>   &twl_gpio {
>>       ti,use-leds;
>>   };
>> +
>> +&usb_otg_hs {
>> +    interface_type = <0>;
>> +    mode = <3>;
>> +    power = <50>;
>> +};
>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>> index 1acc261..b6472f7 100644
>> --- a/arch/arm/boot/dts/omap3.dtsi
>> +++ b/arch/arm/boot/dts/omap3.dtsi
>> @@ -397,5 +397,17 @@
>>               ti,timer-alwon;
>>               ti,timer-secure;
>>           };
>> +
>> +        usb_otg_hs: usb_otg_hs@...ab000 {
>> +            compatible = "ti,omap3-musb";
>> +            reg = <0x480ab000 0x1000>;
>> +            interrupts = <0 92 0x4>, <0 93 0x4>;
>> +            interrupt-names = "mc", "dma";
>> +            ti,hwmods = "usb_otg_hs";
>> +            usb-phy = <&usb2_phy>;
>> +            multipoint = <1>;
>> +            num_eps = <16>;
>> +            ram_bits = <12>;
>
> Where are these bindings documented? The general convention is to use
> a '-' for property names and not '_'

It's documented in Documentation/devicetree/bindings/usb/omap-usb.txt
Actually the documentation and the drivers got merged with this binding 
long back.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/