linux-kernel - Re: [PATCH wireless-next] brcmsmac: fix u16 overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51140C0F.5070209@broadcom.com>
Date:	Thu, 7 Feb 2013 21:18:23 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Tim Gardner" <tim.gardner@...onical.com>
cc:	linux-kernel@...r.kernel.org,
	"Brett Rudley" <brudley@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	"Hante Meuleman" <meuleman@...adcom.com>,
	"John W. Linville" <linville@...driver.com>,
	"Pieter-Paul Giesberts" <pieterpg@...adcom.com>,
	"Seth Forshee" <seth.forshee@...onical.com>,
	"Hauke Mehrtens" <hauke@...ke-m.de>,
	linux-wireless@...r.kernel.org, brcm80211-dev-list@...adcom.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH wireless-next] brcmsmac: fix u16 overflow warning

On 02/07/2013 08:35 PM, Tim Gardner wrote:
> DOT11_MIN_BEACON_PERIOD and DOT11_MAX_BEACON_PERIOD are
> superfluous. The only invalid beacon period is 0. Comparing
> a 16 bit quantity to 0xffff also causes a compile warning:
> 
> drivers/net/wireless/brcm80211/brcmsmac/main.c:5560 brcms_c_set_beacon_period()
>  warn: impossible condition '(period > 65535) => (0-65535 > 65535)'
> 
> Observed from smatch analysis.
> 
> Cc: Brett Rudley <brudley@...adcom.com>
> Cc: "Franky (Zhenhui) Lin" <frankyl@...adcom.com>
> Cc: Hante Meuleman <meuleman@...adcom.com>
> Cc: "John W. Linville" <linville@...driver.com>
> Cc: Pieter-Paul Giesberts <pieterpg@...adcom.com>
> Cc: Seth Forshee <seth.forshee@...onical.com>
> Cc: Hauke Mehrtens <hauke@...ke-m.de>
> Cc: linux-wireless@...r.kernel.org
> Cc: brcm80211-dev-list@...adcom.com
> Cc: netdev@...r.kernel.org

Acked-by: Arend van Spriel <arend@...adcom.com>
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
> ---
>  drivers/net/wireless/brcm80211/brcmsmac/main.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> index c26992a..080b54d 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> @@ -101,8 +101,6 @@
>  #define DOT11_RTS_LEN			16
>  #define DOT11_CTS_LEN			10
>  #define DOT11_BA_BITMAP_LEN		128
> -#define DOT11_MIN_BEACON_PERIOD		1
> -#define DOT11_MAX_BEACON_PERIOD		0xFFFF
>  #define DOT11_MAXNUMFRAGS		16
>  #define DOT11_MAX_FRAG_LEN		2346
>  
> @@ -5555,8 +5553,7 @@ int brcms_c_set_rateset(struct brcms_c_info *wlc, struct brcm_rateset *rs)
>  
>  int brcms_c_set_beacon_period(struct brcms_c_info *wlc, u16 period)
>  {
> -	if (period < DOT11_MIN_BEACON_PERIOD ||
> -	    period > DOT11_MAX_BEACON_PERIOD)
> +	if (period == 0)
>  		return -EINVAL;
>  
>  	wlc->default_bss->beacon_period = period;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/