linux-kernel - Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51140D3D.9020100@broadcom.com>
Date:	Thu, 7 Feb 2013 21:23:25 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Joe Perches" <joe@...ches.com>
cc:	"Tim Gardner" <tim.gardner@...onical.com>,
	linux-kernel@...r.kernel.org,
	"Brett Rudley" <brudley@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	"Hante Meuleman" <meuleman@...adcom.com>,
	"John W. Linville" <linville@...driver.com>,
	"Seth Forshee" <seth.forshee@...onical.com>,
	"Pieter-Paul Giesberts" <pieterpg@...adcom.com>,
	"Hauke Mehrtens" <hauke@...ke-m.de>,
	linux-wireless@...r.kernel.org, brcm80211-dev-list@...adcom.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack
 variable

On 02/07/2013 09:19 PM, Joe Perches wrote:
> On Thu, 2013-02-07 at 13:13 -0700, Tim Gardner wrote:
>> Dynamically allocate the probe response template which
>> avoids potential stack corruption. Observed with smatch:
> 
> trivial:
> 
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> []
>> @@ -7408,9 +7408,16 @@ brcms_c_bss_update_probe_resp(struct brcms_c_info *wlc,
> []
>> +	prb_resp = kmalloc(BCN_TMPL_LEN, GFP_ATOMIC);
>> +	if (!prb_resp) {
>> +		wiphy_err(wlc->wiphy, "wl: %s: failed to alloc %u bytes\n",
>> +			__func__, BCN_TMPL_LEN);
> 
> Please remove the error message.
> alloc's don't need specific OOM messages.
> 
> The mm subsystem already provides a standardized
> message with a dump_stack().

You beat me to the finish line :-)

Gr. AvS


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/