linux-kernel - Re: [tip:x86/hyperv] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <511B0C84.5040806@zytor.com>
Date:	Tue, 12 Feb 2013 19:46:12 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	KY Srinivasan <kys@...rosoft.com>
CC:	Yinghai Lu <yinghai@...nel.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...ux.intel.com" <hpa@...ux.intel.com>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/hyperv] X86: Handle Hyper-V vmbus interrupts as special
 hypervisor interrupts

On 02/12/2013 07:32 PM, KY Srinivasan wrote:
>>>
>>> +#if IS_ENABLED(CONFIG_HYPERV)
>>> +apicinterrupt HYPERVISOR_CALLBACK_VECTOR \
>>> +       hyperv_callback_vector hyperv_vector_handler
>>> +#endif /* CONFIG_HYPERV */
>>> +
>>
>> so #ifdef CONFIG_HYPERV does not work here?
>
> The issue was that you could turn on CONFIG_HYPERV without enabling
> CONFIG_X86_LOCAL_APIC. Peter fixed it.
>

He is asking why you are using IS_ENABLED() instead of #ifdef.  The 
difference is that IS_ENABLED() works even for modules.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/