linux-kernel - Re: [PATCH] [Watchdog][Trivial] Added comments to explain watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130216084245.GD18953@gmail.com>
Date:	Sat, 16 Feb 2013 09:42:45 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Don Zickus <dzickus@...hat.com>
Cc:	anish singh <anish198519851985@...il.com>,
	akpm@...ux-foundation.org, tglx@...utronix.de,
	chuansheng.liu@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [Watchdog][Trivial] Added comments to explain
 watchdog_disabled variable


* Don Zickus <dzickus@...hat.com> wrote:

> > >> > +       /*
> > >> > +        * We shouldn't enable watchdog threads if it is
> > >> > +        * disabled.This is done by watchdog_disabled
> > >> > +        * variable check in watchdog_*_all_cpus function.
> > >
> > > It has two grammatic and a stylistic error in it, plus misses
> > Would you mind pointing it out to me the grammatical mistakes
> > as I am not that good with grammar.
> 
> I am not entirely sure which ones Ingo is referring to, but what I see are
> 
> 'disabled.This' needs a space after period
> 'This is done by watchdog_disabled' needs a 'the' after 'by'
> 'variable check in watchdog..' needs a 'the' after 'in'.
> 
> in addition to the missing ()'s after 'watchdog_*_all_cpus.

There's also a plural/singular mismatch between 'watchdog 
threads' and 'if it is disabled'.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/