linux-kernel - Re: [PATCH v2] clk: Add axi-clkgen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 16 Feb 2013 09:47:40 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Mike Turquette <mturquette@...aro.org>
CC:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] clk: Add axi-clkgen driver

On 02/16/2013 03:52 AM, Mike Turquette wrote:
> Quoting Lars-Peter Clausen (2013-01-23 06:04:52)
>> +static const struct of_device_id axi_clkgen_ids[] = {
>> +       { .compatible = "adi,axi-clkgen-1.00.a" },
>> +       { },
>> +};
>> +MODULE_DEVICE_TABLE(of, axi_clkgen_ids);
> 
> This method is deprecated.  Can you convert over to the newer
> of_clk_init method?  See:
> 
> http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=commit;h=f2f6c2556dcc432e50003bc8fa4d62d95906f149

Hi,

I'm not sure this makes sense here. That would mean completely bypassing the
device driver model. And since this device is on a kind of external bus it may
or may not be present at the time of_clk_init() runs.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/