linux-kernel - Re: [-rc7 regression] Buggy commit: "mm: use aligned zone start for pfn_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwL3+sk4LkwgoV53Qe_F=EkA79mvpRY5ssBopyqiJCf9Q@mail.gmail.com>
Date:	Sat, 16 Feb 2013 11:51:03 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>, Greg KH <gregkh@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jens Axboe <axboe@...nel.dk>,
	Alexander Viro <viro@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>, "H. Peter Anvin" <hpa@...or.com>,
	Laura Abbott <lauraa@...eaurora.org>,
	Mel Gorman <mgorman@...e.de>
Subject: Re: [-rc7 regression] Buggy commit: "mm: use aligned zone start for
 pfn_to_bitidx calculation"

On Sat, Feb 16, 2013 at 11:38 AM, Yinghai Lu <yinghai@...nel.org> wrote:
>
> but you forgot to update setup_usemap() for SPARSEMEM

Heh. I tried desperately to find a config to test my patch in, because
I couldn't see how to even disable SPARSEMEM for my normal x86-64
build. But then I *only* tested it for that non-SPARSEMEM case,
expecting that to be what showed any problems. The fact that I didn't
bother testing my normal config is a bit ironic.

But I'd still like verification that it actually fixes Ingo's issue.
It *looks* like it should, and it would explain the potential for
memory corruption, but perhaps Ingo's odd lock-up is due to something
really subtle and unrelated to the actual allocation size.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/