linux-kernel - Re: [-rc7 regression] Buggy commit: "mm: use aligned zone start for pfn_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130218084937.GC15989@gmail.com>
Date:	Mon, 18 Feb 2013 09:49:37 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Yinghai Lu <yinghai@...nel.org>, Greg KH <gregkh@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jens Axboe <axboe@...nel.dk>,
	Alexander Viro <viro@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Laura Abbott <lauraa@...eaurora.org>,
	Mel Gorman <mgorman@...e.de>
Subject: Re: [-rc7 regression] Buggy commit: "mm: use aligned zone start for
 pfn_to_bitidx calculation"


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> > Right, that's the commit causing the x86 regression:
> >
> >  c060f943d0929f3e429c5d9522290584f6281d6e is the first bad commit
> >  commit c060f943d0929f3e429c5d9522290584f6281d6e
> >  Date:   Fri Jan 11 14:31:51 2013 -0800
> >
> >      mm: use aligned zone start for pfn_to_bitidx calculation
> 
> Ok, looking more at this, I don't really want to revert it, 
> and I have an idea of what is wrong.
> 
> When we allocate the zone use bitmap, we do not take the 
> zone_start_pfn into account. So I *think* that what happens is 
> that "pfn_to_bitidx()" simply overruns the allocation for 
> unaligned zonesm and the spinlock just happens to be right 
> after (or the overrun causes some other memory corruption that 
> then indirectly causes the spinlock corruption).
> 
> So I'm wondering if the fix is simply something like the 
> attached patch. It takes the zone_start_pfn into account when 
> allocating the zone bitmap.
> 
> Laura? Mel?
> 
> Ingo, can you test this? I was going to do the 3.8 today, but 
> I guess I can just wait, and if you can test this we could get 
> it in..

Yes, your patch fixes the bug: with the patch applied to 
f741656d646f plus the failing .config the system booted up
just fine.

I also double checked that vanilla upstream f741656d646f still 
locks up - so it's your patch that made the difference.

Tested-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/