linux-kernel - Re: [PATCH v9 2/3] trace,x86: add x86 irq vector tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5122BE0C.9020403@zytor.com>
Date:	Mon, 18 Feb 2013 15:49:32 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Seiji Aguchi <seiji.aguchi@....com>
CC:	Steven Rostedt <rostedt@...dmis.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Thomas Gleixner (tglx@...utronix.de)" <tglx@...utronix.de>,
	"'mingo@...e.hu' (mingo@...e.hu)" <mingo@...e.hu>,
	"Borislav Petkov (bp@...en8.de)" <bp@...en8.de>,
	Satoru Moriya <satoru.moriya@....com>,
	"dle-develop@...ts.sourceforge.net" 
	<dle-develop@...ts.sourceforge.net>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Luck, Tony (tony.luck@...el.com)" <tony.luck@...el.com>
Subject: Re: [PATCH v9 2/3] trace,x86: add x86 irq vector tracepoints

On 02/18/2013 03:45 PM, Seiji Aguchi wrote:
>>> Not-yet-signed-off-by: Steven Rostedt <rostedt@...dmis.org>
>>>
>>> ... so I was holding off on doing anything with it.
>>
>> Heh, and I was waiting for comments from you before doing anything further with it ;-)
>>
>> Email review deadlock!
>
> So, how do you plan to push ahead with this patch?
>
> https://lkml.org/lkml/2013/2/1/532
>
> <snip>
> I think I got all the cases, as NMIs causes the store/restore functions to be re-entrent without any locks.
> <snip>
>
> Steven,
> if you think you got all the cases, you can do more testing.
> What is your concern?
>
> I hope this patch will be included in 3.9.
>

What about the following:

> The base address of the IDT doesn't generally change... the one
> exception is when we do the funny NMI workaround.
>
> For that reason, I would be happier if we just restored the standard
> value instead of saving/restoring stuff.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/