linux-kernel - Re: [patch 1/2] kcmp: Make it to depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5123F32B.3000401@zytor.com>
Date:	Tue, 19 Feb 2013 13:48:27 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Michal Marek <mmarek@...e.cz>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, ebiederm@...ssion.com,
	xemul@...allels.com, Andrey Vagin <avagin@...nvz.org>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Glauber Costa <glommer@...allels.com>,
	Andi Kleen <andi@...stfloor.org>, Tejun Heo <tj@...nel.org>,
	Matt Helsley <matthltc@...ibm.com>,
	Pekka Enberg <penberg@...nel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

On 02/19/2013 01:42 PM, Andrew Morton wrote:
>> Index: linux-2.6.git/kernel/Makefile
>> ===================================================================
>> --- linux-2.6.git.orig/kernel/Makefile
>> +++ linux-2.6.git/kernel/Makefile
>> @@ -25,9 +25,7 @@ endif
>>   obj-y += sched/
>>   obj-y += power/
>>
>> -ifeq ($(CONFIG_CHECKPOINT_RESTORE),y)
>> -obj-$(CONFIG_X86) += kcmp.o
>> -endif
>> +obj-$(CONFIG_KCMP) += kcmp.o
>>   obj-$(CONFIG_FREEZER) += freezer.o
>>   obj-$(CONFIG_PROFILING) += profile.o
>>   obj-$(CONFIG_STACKTRACE) += stacktrace.o
>
> This permits people to select kcmp with CONFIG_CHECKPOINT_RESTORE=n.
> Is there any point in doing that?
>
> What would be wrong with just doing
>
> 	obj-$(CONFIG_CHECKPOINT_RESTORE) += kcmp.o
>

The real question is if there are any potential use cases of kcmp() 
outside checkpoint/restore.  It is actually a very general facility.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/