linux-kernel - [PATCH] mm: slab: Verify the nodeid passed to ____cache_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <943811281.6485888.1361484478519.JavaMail.root@redhat.com>
Date:	Thu, 21 Feb 2013 17:07:58 -0500 (EST)
From:	Aaron Tomlin <atomlin@...hat.com>
To:	linux-mm@...ck.org
Cc:	linux-kernel@...r.kernel.org, Rik <riel@...hat.com>
Subject: [PATCH] mm: slab: Verify the nodeid passed to ____cache_alloc_node

Hi,

The addition of this BUG_ON should make debugging easier.
While I understand that this code path is "hot", surely
it is better to assert the condition than to wait until
some random NULL pointer dereference or page fault. If the
caller passes an invalid nodeid, at this stage in my opinion
it's already a BUG.

Cheers,
Aaron

---8<---
mm: slab: Verify the nodeid passed to ____cache_alloc_node

If the nodeid is > num_online_nodes() this can cause an
Oops and a panic(). The purpose of this patch is to assert
if this condition is true to aid debugging efforts rather
than some random NULL pointer dereference or page fault.

Signed-off-by: Aaron Tomlin <atomlin@...hat.com>

 slab.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/slab.c b/mm/slab.c
index e7667a3..735e8bd 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3412,6 +3412,7 @@ static void *____cache_alloc_node(struct kmem_cache *cachep, gfp_t flags,
 	void *obj;
 	int x;

+	BUG_ON(nodeid > num_online_nodes());
 	l3 = cachep->nodelists[nodeid];
 	BUG_ON(!l3);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/